Skip to content

[v2.6.x] Upgrade to CUDA 12.9, fix osx builds#408

Closed
iamthebot wants to merge 19 commits into
conda-forge:v2.6.xfrom
iamthebot:al--fix_cuda_12.9
Closed

[v2.6.x] Upgrade to CUDA 12.9, fix osx builds#408
iamthebot wants to merge 19 commits into
conda-forge:v2.6.xfrom
iamthebot:al--fix_cuda_12.9

Conversation

@iamthebot
Copy link
Copy Markdown

@iamthebot iamthebot commented Aug 6, 2025 •
edited
Loading

This is basically #405 but with an additional patch file (0019) that backports a fix from PyTorch 2.7+ so tensorpipe compilation doesn't fail. This fixes the OSX build.

There are a few (4) test failures though that seem unrelated. Perhaps we can add this patch to #405?

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-admin
Copy link
Copy Markdown
Contributor

conda-forge-admin commented Aug 6, 2025 •
edited
Loading

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • ℹ️ The recipe is not parsable by parser conda-souschef (grayskull). This parser is not currently used by conda-forge, but may be in the future. We are collecting information to see which recipes are compatible with grayskull.
  • ℹ️ The recipe is not parsable by parser conda-recipe-manager. The recipe can only be automatically migrated to the new v1 format if it is parseable by conda-recipe-manager.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/17363174359. Examine the logs at this URL for more detail.

@iamthebot iamthebot mentioned this pull request Aug 6, 2025
Closed
@iamthebot iamthebot marked this pull request as ready for review August 6, 2025 17:23
h-vetinari
h-vetinari requested changes Aug 12, 2025
View reviewed changes
Comment thread recipe/meta.yaml Outdated
@h-vetinari h-vetinari changed the base branch from main to v2.6.x August 12, 2025 02:22
@h-vetinari h-vetinari changed the title Fix OSX Builds for Cuda 12.9/Pytorch 2.6.0 upgrade [v2.6.x] Upgrade to CUDA 12.9, fix osx builds Aug 12, 2025
@h-vetinari
Copy link
Copy Markdown
Member

h-vetinari commented Aug 12, 2025

There are a few (4) test failures though that seem unrelated.

Can you please provide the logs / test traces where you saw this? We can add skips where the failures are not critical

@iamthebot
Copy link
Copy Markdown
Author

iamthebot commented Aug 13, 2025 •
edited
Loading

There are a few (4) test failures though that seem unrelated.

Can you please provide the logs / test traces where you saw this? We can add skips where the failures are not critical

Seems to be the same 4 tests on all the OSX runners:

FAILED [0.0042s] test/test_linalg.py::TestLinalgCPU::test_norm_matrix_degenerate_shapes_cpu_complex128 - AssertionError: ValueError not raised

To execute this test, run the following from the base repo dir:
    python test/test_linalg.py TestLinalgCPU.test_norm_matrix_degenerate_shapes_cpu_complex128

This message can be suppressed by setting PYTORCH_PRINT_REPRO_ON_FAILURE=0
FAILED [0.0037s] test/test_linalg.py::TestLinalgCPU::test_norm_matrix_degenerate_shapes_cpu_complex64 - AssertionError: ValueError not raised

To execute this test, run the following from the base repo dir:
    python test/test_linalg.py TestLinalgCPU.test_norm_matrix_degenerate_shapes_cpu_complex64

This message can be suppressed by setting PYTORCH_PRINT_REPRO_ON_FAILURE=0
FAILED [0.0041s] test/test_linalg.py::TestLinalgCPU::test_norm_matrix_degenerate_shapes_cpu_float32 - AssertionError: ValueError not raised

To execute this test, run the following from the base repo dir:
    python test/test_linalg.py TestLinalgCPU.test_norm_matrix_degenerate_shapes_cpu_float32

This message can be suppressed by setting PYTORCH_PRINT_REPRO_ON_FAILURE=0
FAILED [0.0063s] test/test_linalg.py::TestLinalgCPU::test_norm_matrix_degenerate_shapes_cpu_float64 - AssertionError: ValueError not raised

Let me take a closer look tomorrow and see if these are safe/reasonable to skip.

@shermansiu shermansiu mentioned this pull request Aug 31, 2025
Merged
@h-vetinari h-vetinari closed this Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@h-vetinari h-vetinari h-vetinari requested changes

@Tobias-Fischer Tobias-Fischer Awaiting requested review from Tobias-Fischer Tobias-Fischer is a code owner

@baszalmstra baszalmstra Awaiting requested review from baszalmstra baszalmstra is a code owner

@beckermr beckermr Awaiting requested review from beckermr beckermr is a code owner

@benjaminrwilson benjaminrwilson Awaiting requested review from benjaminrwilson benjaminrwilson is a code owner

@hmaarrfk hmaarrfk Awaiting requested review from hmaarrfk hmaarrfk is a code owner

@jeongseok-meta jeongseok-meta Awaiting requested review from jeongseok-meta jeongseok-meta is a code owner

@mgorny mgorny Awaiting requested review from mgorny mgorny is a code owner

@sodre sodre Awaiting requested review from sodre sodre is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@iamthebot @conda-forge-admin @h-vetinari @isuruf @regro-cf-autotick-bot